Skip to content

Conversation

@xstefank
Copy link
Collaborator

We want to provide CDI beans in the Condition subclasses as requested in quarkiverse/quarkus-operator-sdk#720.

Copilot AI review requested due to automatic review settings September 24, 2025 11:26
@openshift-ci openshift-ci bot requested review from csviri and metacosm September 24, 2025 11:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables CDI bean injection in Condition subclasses by making DependentResourceNode creation configurable through the DependentResourceFactory. This allows frameworks like Quarkus to override node creation and inject dependencies into conditions.

  • Made DependentResourceNode class public for external extensibility
  • Replaced direct node construction with factory method delegation
  • Added default createNodeFrom method to DependentResourceFactory interface

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
DependentResourceNode.java Changed class visibility from package-private to public
DefaultManagedWorkflow.java Replaced direct node instantiation with factory method call
DependentResourceFactory.java Added default createNodeFrom method for customizable node creation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@csviri
Copy link
Collaborator

csviri commented Sep 24, 2025

I'm fine with this but @metacosm is more competent to review it, let's wait for him too

@csviri csviri merged commit e181b0f into operator-framework:main Sep 24, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants