Skip to content

Conversation

@csviri
Copy link
Collaborator

@csviri csviri commented Oct 18, 2025

the test sometimes fails, we will iterate on this in any ways

the test sometimes fails, we will iterate on this in any ways

Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri requested a review from xstefank October 18, 2025 14:56
@openshift-ci openshift-ci bot requested a review from metacosm October 18, 2025 14:56
Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri merged commit 27f050c into next Oct 18, 2025
25 checks passed
@csviri csviri deleted the disable-perf-test branch October 18, 2025 18:33
shawkins pushed a commit to shawkins/java-operator-sdk that referenced this pull request Oct 21, 2025
@metacosm
Copy link
Collaborator

This test pretty much fails all the time on my system and the difference is considerable (i.e.Long.parseLong is consistently more than 10 times faster) so we definitely need to review the implementation and figure out what to do. It might not make sense to hand-craft a parser if it cannot be made substantially faster than the "default" parsing + some extra validation.

@csviri
Copy link
Collaborator Author

csviri commented Oct 23, 2025

Yeah, it was not failing for me locally, we will iterate on this also based on prs of @shawkins in 5.3
simple parsing won't validate all the cases though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants