removing tombstones #3013
removing tombstones #3013
Conversation
Signed-off-by: Steve Hawkins <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
| return this; | ||
| } | ||
|
|
||
| public Builder<R> parseResourceVersionsForEventFilteringAndCaching(boolean parse) { |
There was a problem hiding this comment.
comparableResourceVersions we should probably have this also as withComparableResourceVersions(boolean) that is a more generic name.
There was a problem hiding this comment.
I did this to be consistent with the other configuration for now. I can use a different name to start with here, or we can use a follow-up issue on how to approach the renaming in general.
| private PrimaryToSecondaryMapper<?> primaryToSecondaryMapper; | ||
| private SecondaryToPrimaryMapper<R> secondaryToPrimaryMapper; | ||
| private KubernetesClient kubernetesClient; | ||
| private boolean comparableResourceVersions = true; |
There was a problem hiding this comment.
We should add this also to @KubernetesDependent annotation.
| log.debug("Resource found in cache: {} for id: {}", res.isPresent(), resourceID); | ||
| return res; | ||
| } | ||
| log.debug( |
There was a problem hiding this comment.
Would it make sense also to log if parseResourceVersions is true/false? But that might be trivial to see.
|
|
||
| public Optional<String> getLastSyncResourceVersion(Optional<String> namespace) { | ||
| return getSource(namespace.orElse(WATCH_ALL_NAMESPACES)) | ||
| .map(source -> source.getLastSyncResourceVersion()); |
There was a problem hiding this comment.
nit: can be replaced by methode reference
There was a problem hiding this comment.
Sorry, this can be removed - see #3015
| .getResourceVersion() | ||
| .equals(previousResourceVersion)) | ||
| || isLaterResourceVersion(resourceId, newResource, cachedResource))) { | ||
| // first check against the source in general - this also prevents resurrecting resources when |
There was a problem hiding this comment.
Could you pls expand the comment, and explain more in details (maybe sequence of events) how this prevents resurrection ?
2 participants
Replaces: #2989 to target v5.3
Adds per informer configuration and uses the configuration for the primary resource.
Probably superceded by : #3015 - at the very least some changes from there are needed here.