Skip to content

Conversation

@csviri
Copy link
Collaborator

@csviri csviri commented Oct 24, 2025

No description provided.

Will check if this could be elegantly extended to bulk resources

Signed-off-by: Attila Mészáros <[email protected]>
…s and bulk dependents

Signed-off-by: Attila Mészáros <[email protected]>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Collaborator Author

@csviri csviri Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a deletion of empty file, it is not needed.

csviri and others added 6 commits October 27, 2025 17:08
…tor/processing/ResourceIDMapper.java

Co-authored-by: Martin Stefanko <[email protected]>
…tor/processing/ResourceIDMapper.java

Co-authored-by: Martin Stefanko <[email protected]>
…tor/processing/ResourceIDProvider.java

Co-authored-by: Martin Stefanko <[email protected]>
…tor/processing/ResourceIDProvider.java

Co-authored-by: Martin Stefanko <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri csviri requested a review from xstefank October 29, 2025 08:55
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Copy link
Collaborator

@xstefank xstefank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small stuff, otherwise good

metacosm and others added 2 commits October 30, 2025 17:17
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several comments:

  • As previously mentioned, I don't think that putting the responsibility of providing the external resource id on the external resource class is a good idea. We need to decide which design to go with now because this is already a breaking change and it shouldn't change again soon after, if we decide that putting the id "generation" on the dependent class (for example) is a better design later.
  • The documentation for this feature is rather lacking and doesn't really explain the concepts or how to use things so it needs to be improved, imo.

@csviri
Copy link
Collaborator Author

csviri commented Oct 30, 2025

As previously mentioned, I don't think that putting the responsibility of providing the external resource id on the external resource class is a good idea.

That is completely optional, but allows us to add meaningful default implementation for the mapper. What alternative would you propose?

if we decide that putting the id "generation" on the dependent class (for example) is a better design later.

Not shure what do you mean by this. Can you pls elaborate?

The documentation for this feature is rather lacking and doesn't really explain the concepts or how to use things so it needs to be improved, imo.

Yeah, in general we have quite badly documented, features around it, would rather followup with a comprehensive rework on the docs.

it is by definition single, so namespace scoping is out of the picture, also does not confuse this way
with some hidden intention in the background

Signed-off-by: Attila Mészáros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improved default setup for External Dependent Resource for selecting and/or matching resources

4 participants