Skip to content

fix: use close as destroyMethod of Bean #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2021
Merged

fix: use close as destroyMethod of Bean #645

merged 1 commit into from
Nov 2, 2021

Conversation

@KimDoubleB
Copy link

@KimDoubleB KimDoubleB commented Nov 2, 2021

Operator does not have a stop method.
In accordance with the meaning, instead of the stop method, the close method was modified to operate as destroyMethod .

@csviri
Copy link
Collaborator

csviri commented Nov 2, 2021

Thx @KimDoubleB . good catch!

@csviri csviri merged commit 767858d into operator-framework:master Nov 2, 2021
@KimDoubleB KimDoubleB deleted the fix/sample-bean-destory branch November 2, 2021 10:04
adam-sandor pushed a commit that referenced this pull request Nov 5, 2021
@KimDoubleB @adam-sandor
fix: use close as destroyMethod of Bean (#645)
c34aa65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KimDoubleB @csviri