Skip to content

Conversation

joelanford
Copy link
Member

Description

I found some dead code (k8sutil) and a copy of a controller-runtime Server implementation that we implemented, contributed to controller-runtime, and then forgot to switch to once there was a controller-runtime release that included it.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner January 19, 2025 19:04
@netlify
Copy link

netlify bot commented Jan 19, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit f437909
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/678d4cd89d0d52000835cadd
😎 Deploy Preview https://deploy-preview-1637--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.35%. Comparing base (96972f0) to head (f437909).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
catalogd/internal/serverutil/serverutil.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1637      +/-   ##
==========================================
+ Coverage   66.76%   67.35%   +0.59%     
==========================================
  Files          57       55       -2     
  Lines        4600     4555      -45     
==========================================
- Hits         3071     3068       -3     
+ Misses       1303     1261      -42     
  Partials      226      226              
Flag Coverage Δ
e2e 53.08% <ø> (ø)
unit 54.18% <0.00%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2025
@joelanford joelanford added this pull request to the merge queue Jan 20, 2025
Merged via the queue into operator-framework:main with commit 594cba3 Jan 20, 2025
22 of 23 checks passed
@joelanford joelanford deleted the catalogd-cleanup branch February 14, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants