Skip to content

Conversation

joelanford
Copy link
Member

Description

Found one spot we missed on our docs when we changed ClusterExtension.spec.source.catalog.{channel -> channels}

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner February 10, 2025 18:07
@netlify
Copy link

netlify bot commented Feb 10, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 40b9696
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67aa40474d2a410007aaae24
😎 Deploy Preview https://deploy-preview-1741--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.36%. Comparing base (a38da78) to head (40b9696).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1741      +/-   ##
==========================================
+ Coverage   68.24%   68.36%   +0.12%     
==========================================
  Files          58       58              
  Lines        4988     4988              
==========================================
+ Hits         3404     3410       +6     
+ Misses       1342     1338       -4     
+ Partials      242      240       -2     
Flag Coverage Δ
e2e 53.00% <ø> (+0.08%) ⬆️
unit 55.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2025
@joelanford joelanford added this pull request to the merge queue Feb 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 10, 2025
@joelanford joelanford added this pull request to the merge queue Feb 10, 2025
Merged via the queue into main with commit c0a2964 Feb 10, 2025
22 checks passed
@joelanford joelanford deleted the joelanford-patch-1 branch May 16, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants