-
Notifications
You must be signed in to change notification settings - Fork 43
Feature/auto pruning #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
everettraven
merged 12 commits into
operator-framework:main
from
everettraven:feature/auto-pruning
May 10, 2022
Merged
Feature/auto pruning #105
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3e98659
update prune package
everettraven 3f60543
address review comments (partial)
everettraven 6768874
updates based on review comments
everettraven b850c0b
update tests for linting checks
everettraven c39650e
update tests
everettraven 88fb3e0
update tests and nil verification
everettraven 264c78d
Add common strategy functions
everettraven 3bf051a
Add common strategies
everettraven 230e74e
update sorting to save some CPU cycles
everettraven be7adfb
remove logger
everettraven 7fb8237
export IsUnprunable
everettraven f881c0d
updates from review
everettraven File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // Copyright 2021 The Operator-SDK Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package prune | ||
|
|
||
| import ( | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
|
|
||
| batchv1 "k8s.io/api/batch/v1" | ||
| corev1 "k8s.io/api/core/v1" | ||
| ) | ||
|
|
||
| // DefaultPodIsPrunable is a default IsPrunableFunc to be used specifically with Pod resources. | ||
| // It marks a Pod resource as prunable if it's Status.Phase is "Succeeded" | ||
| // This can be overridden by registering your own IsPrunableFunc via the RegisterIsPrunableFunc method | ||
| func DefaultPodIsPrunable(obj client.Object) error { | ||
| pod := obj.(*corev1.Pod) | ||
| if pod.Status.Phase != corev1.PodSucceeded { | ||
| return &Unprunable{ | ||
| Obj: &obj, | ||
| Reason: "Pod has not succeeded", | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // DefaultJobIsPrunable is a default IsPrunableFunc to be used specifically with Job resources. | ||
| // It marks a Job resource as prunable if it's Status.CompletionTime value is not `nil`, indicating that the Job has completed | ||
| // This can be overridden by registering your own IsPrunableFunc via the RegisterIsPrunableFunc method | ||
| func DefaultJobIsPrunable(obj client.Object) error { | ||
| job := obj.(*batchv1.Job) | ||
| if job.Status.CompletionTime == nil { | ||
| return &Unprunable{ | ||
| Obj: &obj, | ||
| Reason: "Job has not completed", | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.