feat: Add ODP Segments support in Audience Evaluation #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zashraf1985
suggested changes
Jun 7, 2022
| this.userId = userId; | ||
| if (attributes != null) { | ||
| this.attributes = Collections.synchronizedMap(new HashMap<>(attributes)); | ||
| } else { |
There was a problem hiding this comment.
Consolidate both the constructor methods to remove redunduncy
| Object userAttributeValue = attributes.get(name); | ||
|
|
||
| if (!"custom_attribute".equals(type)) { | ||
| if (!"custom_attribute".equals(type) && !"third_party_dimension".equals(type)) { |
There was a problem hiding this comment.
Can you add it to constant list or enum and add a generic check for valid types
resolved issue with assert
This reverts commit 794e082.
|
Closing this PR as all the changes were already done in PR 474 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added ODP Segments support in Audience evaluation
Test plan