Improved pull request "Files Changed" experience feedback #163932
Replies: 2286 comments 802 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
|
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
-
|
Is there a way to "Hide all comments" comparable to the "Show comments" toggle? |
Beta Was this translation helpful? Give feedback.
-
|
Just too much faff to use with large PRs, so I've disabled for now. I'm assuming these are just temporary restrictions while you deal with the performance issues. Also as a selection reader I find the text editor UI irritating, so it'd be nice if there were a way to make it not an editor. |
Beta Was this translation helpful? Give feedback.
-
|
nice and clean. great change. thanks |
Beta Was this translation helpful? Give feedback.
-
|
Just checking if there's the ability to toggle "blame" mode to see who made the change inside the view? |
Beta Was this translation helpful? Give feedback.
-
|
This new experience on a PR with a large number of files is horrific. Switching between files is extremely slow (about a 2-3 second delay per file change), and if you need to jump back to a previous file for context, it's difficult to navigate (yes, there is the left side navigation, but that doesn't indicate what you have already looked at, so you spend time scrolling through trying to find where you were previously). |
Beta Was this translation helpful? Give feedback.
-
|
Can we have a scroll to top button? Cheers |
Beta Was this translation helpful? Give feedback.
-
|
Keyboard shortcuts doesn't work, such as navigating a file with |
Beta Was this translation helpful? Give feedback.
-
|
On larger PRs it automatically switches to viewing 1 file at a time. I really dislike this. In order to really understand the proposed changes I often have to go back and forth between files being referenced and this is much more difficult in the experience Additionally if I mark some files as viewed and leave mid review and then return, it starts me at the first file again, it's still mark as viewed and I can't progress on the review without then unchecking it as viewed first. |
Beta Was this translation helpful? Give feedback.
-
the PR now only shows one file’s diff at once. Combined with the slow file loading, this makes the overall experience quite poor. |
Beta Was this translation helpful? Give feedback.
-
|
Not having all the comments displayed when reaching the 40 comments limits is confusing. I though that Github deleted my comments so I recreated them, and after I discovered at the top of the page the warning about all the comments not displayed. And so I needed, to delete my duplicates |
Beta Was this translation helpful? Give feedback.
-
|
The new experience looks great comment wise, but i just hit a bug: when trying to view "Changes since your last review" the |
Beta Was this translation helpful? Give feedback.
-
|
The new experience is so slow with a PR with 68 files. Had to switch back. |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Overall the new version is either net better or net neutral. I especially like that pending comments are all listed in the submit review dialogue. Don't love that selecting a range of commits now requires an extra click to open the dialogue. The new UI should just be rendered in the dropdown. But besides that like the explicit checkbox approach for making it easier to select a range of commits I am also once again asking, begging for keyboard shortcuts. It's a big part of why my team has switched over to Graphite. Their shortcut game is great |
Beta Was this translation helpful? Give feedback.
-
|
My PR have 62 files with changes, on old ui, I was able to see all changes with infinite scroll but, on the new version, I need to open one by one: "Due to the large number of changes in this pull request, only one file is being shown at a time." This is why I prefer the old version. |
Beta Was this translation helpful? Give feedback.























Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Important
You can opt in to the public preview from any pull request via
✨Try the new experiencein the upper-right corner. You can return to the classic view by clicking the “switch back” link.About the new experience
This refresh focuses on performance, accessibility, and clarity so reviews stay responsive—even on the largest pull requests.
What’s new ?
Performance 🚀
UX ✨
Accessibility
What's missing? 🟨
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions