Assign yourself as a reviewer of your own pull request #6292
Replies: 61 comments 46 replies
|
If it's your own pull you probably don't need to assign a particular reviewer, considering you can just review it yourself without assignment. |
|
There are definitely other reasons that this should be supported. My immediate example is: If you create an MR using a branch developed by someone else, but still want to follow a standardized review process with proper assignments. |
|
I am lead in my repo and created a pull request for a commit from another junior dev. He was not able to do it so I wanted to do it for him so I could get the ball rolling. Now I cannot review the pull request because I technically initiated it. Seems all GitHub has to do is take out the condition that the requester cannot be in the reviewers group. Just my two cents. |
|
Another use case for reviewing your own PR: I created a PR for a repo where I'm a collaborator. I then worked with the owner to implement some changes, but in the process I noticed a likely mistaken change that should be resolved before a merge. Specifically, a |
|
Now that there is a YOLO badge for people who let un-reviewed PRs go through, I'm being publically shamed for creating reviews for myself that I cannot approve. 😄 |
|
The SLSA framework allows for trusted contributors to be 1 of 2 minimum reviewers on merges. It still protects against un-validated submissions, but does cut the red tape somewhat for senior team members and alleviate staffing requirements or people doing things not really part of their role. I'd love to see support in Github to assign this by team membership. |
|
It remains extremely short-sighted that this is not possible. |
|
Alternative suggestion: Create the PR as draft, then turn it into a real request. Possibly, you could fetch that type of event to check for a "final" PR to be merged and consider it as reviewed. |
|
I want to do the same myself. I am the owner and sole contributor. But I want to learn more about the GitHub process. |
|
I have found the solution works for me; I am the only one working in the repository, so it may not be appropriate for other situations. On the settings page, select "Branches". Select "Edit" in the Branch Protection Rule.
|
Don't know ! but count me in, I wanna review myself :) |
|
Seconded, another good use case is automated pull request workflows, the author (a bot in this case) should be able to approve it's own PR if it's something trivial and checks all pass. |
|
I don't think that auto-approving pull requests is a good idea. I think a
human should be involved in approving pull requests. What happens if
automation breaks the build process?
Ralph
…On Mon, Dec 12, 2022, 6:53 AM Rees Pozzi ***@***.***> wrote:
Seconded, another good use case is automated pull request workflows, the
author (a bot in this case) should be able to approve it's own PR if it's
something trivial and checks all pass.
It would be nice to keep the required reviews in place for PR's authored
by humans, but allow complete auto-merge functionality for bots
—
Reply to this email directly, view it on GitHub
<#6292 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHZ2PYWBE5ABAXX3IUYA3V3WM4G2JANCNFSM5F5L4RWQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Throwing my 2c into this for a use case. I'm currently the only dev at a small biz and trying to setup the dev pipeline to be compliant with a number of industry certifications. Most of those, around the area of change management, require some approval process for changes into production (which I use a CI pipeline based off the master branch to do). I would be nice if self approval worked out of the box as that would allow a process to be in place that scales right out of the box and is consistent. |
|
One more thing besides all of the other comments: |
|
Another use case - |
|
Can't believe this issue remains unresolved. You need to manually merge after approval. |
|
Super annoying, what the hell Github... |
|
This would be a very useful option to add. I have ran into mutiple situations where this would have been helpful. The most recent one was a PR where everyone on the team contributed something to it. This forced the creator of the PR to leave there feedback outside of GitHub. |
|
In an era where various AI is involved in some, or all, parts of code generation (and unattribued with a distinct committer or github user), being able to "self review" a PR is becoming necessary. Not to work around any PR rules, but simply as another step in the workflow. |
|
@github It's time to allow assign self as reviewer and allow review own PR |
|
Everyone, I am going to save you some time. I have been monitoring this thread for over 3 years, Github has no intentions of bringing this feature to production. It is seemingly an obvious use case that every single person in here would want, but for some reason it is either not a priority for the dev team to add or it has been deemed as a feature that doesn't need to be added ever. |
|
it’s mostly a design + process choice, not a technical limitation. Platforms like GitHub intentionally discourage or block self-review to preserve the meaning of “review.” |
|
I was able to get around it by adding admins as a condition of the bypass list. This works in my case since the other people in the repo are going to be maintainers. This may not work in all situations though, i.e when there is multiple admins. Maybe utilizing custom roles would work. Either way it seems kind of rigid as you can't select a particular user. I understand that GitHub is meant to be a collaboration platform but as the project admin, I would rather be able to merge my own PRs. |
|
+1, make it happen GitHub team... |
|
Will this happen in 2026? |
|
i need |
|
Would love to see this implemented. It would be nice to still follow a standard procedure even if you're the owner of a repository or something. |
|
Here comes a sassy developer. In the year of our good lord 2026 I still can't believe a multi Trillion dollar company can't prioritize this with how much the community is asking. |
|
This would be great for my reviewer subagents |
Uh oh!
There was an error while loading. Please reload this page.
It may sound weird, but there are cases where I wanted to review myself. Is there any reason why the creator of a given pull request cannot be assigned as a reviewer?
All reactions