Skip to content

Conversation

parsonsmatt
Copy link
Owner

@parsonsmatt parsonsmatt commented Mar 10, 2022

This PR adds a variant of the API that uses MonadUnliftIO instead of MonadCatch and MonadThrow. Mostly because that's how we roll at work.

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR.
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts).

, checkpointCallStackWith
-- * Handling Exceptions
, catch
, catches
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmao

-- to "see through" any 'AnnotatedException's.
--
-- @since 0.1.1.0
-- @since 0.1.2.0
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s i g h

Comment on lines +86 to +87
withRunInIO $ \runInIO ->
liftIO $ Catch.checkpointMany anns (runInIO action)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b o r i n g

@parsonsmatt parsonsmatt merged commit 4df4fe6 into master Mar 10, 2022
@parsonsmatt parsonsmatt deleted the matt/add-unliftio-variant branch March 10, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant