Skip to content

PMM-5837 upgrade lib/pq #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 9, 2021
Merged

PMM-5837 upgrade lib/pq #26

merged 6 commits into from
Feb 9, 2021

Conversation

Dasio
Copy link

@Dasio Dasio commented Dec 18, 2020

@it-percona-cla
Copy link

it-percona-cla commented Dec 18, 2020

CLA assistant check
All committers have signed the CLA.

@Dasio Dasio changed the title Pmm 5837 upgrade lib/pq PMM-5837 upgrade lib/pq Dec 18, 2020
@Dasio Dasio requested a review from AlekSi January 8, 2021 12:25
@AlekSi AlekSi removed their request for review January 18, 2021 12:19
@askomorokhov
Copy link

@Dasio, Travis CI fails on registry.go:53:34: too many arguments in call to NewProcessCollector.
And could you please create/link a feature build for this PR?

@rnovikovP
Copy link

pls see https://jira.percona.com/browse/PMM-7344

We need to keep our Exporter as much as possible the same to the upstream.

It's probably better to update the exporter first to match the upstream version and then fix the bug in our version and send it to upstream

@Dasio Dasio merged commit b3cc89e into master Feb 9, 2021
@Dasio Dasio deleted the PMM-5837-upgrade-lib/pq branch February 9, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants