PMM-7896 Updated DB discovery query #34
Conversation
| result = append(result, databaseName) | ||
| } | ||
|
|
||
| if rows.Err() != nil { | ||
| return nil, errors.New(fmt.Sprintln("error retrieving rows:", err)) |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(fmt.Sprintln("error retrieving rows:", err))" (goerr113)
There was a problem hiding this comment.
I didn't want to change it because upstream is not using newer libraries.
The correct way would be use errors.Wrap. There are other parts where the exporting is comparing error types instead using errors.As, etc, but to not to differ too much from upstream, I didn't want to change them.
If you take a look, it is a copy of the error 2 lines above.
| result = append(result, databaseName) | ||
| } | ||
|
|
||
| if rows.Err() != nil { | ||
| return nil, errors.New(fmt.Sprintln("error retrieving rows:", err)) |
| FROM pg_database | ||
| WHERE datallowconn = true | ||
| AND datistemplate = false | ||
| AND has_database_privilege(current_user, datname, 'connect')` |
There was a problem hiding this comment.
Could you please aline this query? :)
|
Carlos Salguero seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Updated the database discovery query to list only the databases the current user has access to.
For RDS instances, the original query was returning the
rdsadmindatabase but that's an RDS internal DB and no other users has access to it so, connections were failing.