Skip to content

PMM-8787 Concurrency in exporter. #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 5, 2021

Conversation

JiriCtvrtka
Copy link

No description provided.

@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 20, 2021 06:11 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 20, 2021 06:11 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 20, 2021 06:11 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 20, 2021 06:13 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 20, 2021 06:13 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 20, 2021 06:13 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 20, 2021 06:20 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 20, 2021 06:20 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 20, 2021 06:20 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 20, 2021 06:26 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 20, 2021 06:26 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 20, 2021 06:26 Inactive
@JiriCtvrtka JiriCtvrtka marked this pull request as ready for review September 20, 2021 06:33
@jprukner jprukner self-requested a review September 21, 2021 11:40
Copy link

@jprukner jprukner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main issue I see is not using actual deep copies. Then the locking with one mutex - not sure what performance consequences are there.

@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 21, 2021 12:34 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 24, 2021 13:35 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 24, 2021 13:35 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 24, 2021 13:35 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 24, 2021 13:43 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 24, 2021 13:43 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 24, 2021 13:43 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 24, 2021 13:45 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 24, 2021 13:45 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 24, 2021 13:45 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 29, 2021 12:19 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 29, 2021 12:19 Inactive
@JiriCtvrtka JiriCtvrtka temporarily deployed to CI September 29, 2021 12:19 Inactive
@percona-csalguero percona-csalguero merged commit 57c8981 into master Oct 5, 2021
@percona-csalguero percona-csalguero deleted the PMM-8787-concurrency-fix branch October 5, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants