-
Notifications
You must be signed in to change notification settings - Fork 149
[FEATURE] Add LogQuery support and related data structures and queries #3163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Alexander Belyakin <[email protected]>
Signed-off-by: Alexander Belyakin <[email protected]>
|
@abelyakin small comment other than that LGTM. |
Co-authored-by: Gabriel Bernal <[email protected]> Signed-off-by: Alexander Belyakin <[email protected]>
b69c7e6 to
b1065fb
Compare
|
@abelyakin regarding your last comment for the Loki & ClickHouse plugin, do you need to update this PR ? |
Signed-off-by: Alexander Belyakin <[email protected]>
@Nexucis Yes, this PR would need updates, since logQuery response should be converted into a unified logs format. But as I mentioned in the Loki datasource plugin PR, my suggestion is to handle that as a separate follow-up PR (new feature), rather than mixing it into the current changes. Is that okay? |
|
yeah it's ok @abelyakin let's start by that and we will iterate base on that. Thank you for your help already ! |
Description
Adds necessary models and queries for LogQuery type
We need it for #perses/plugins/178
relates to #2999
Screenshots
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes
See e2e docs for more details. Common issues include: