Skip to content

Conversation

@abelyakin
Copy link
Contributor

Description

Adds necessary models and queries for LogQuery type

We need it for #perses/plugins/178
relates to #2999

Screenshots

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky.
    See e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@jgbernalp
Copy link
Contributor

@abelyakin small comment other than that LGTM.

Co-authored-by: Gabriel Bernal <[email protected]>
Signed-off-by: Alexander Belyakin <[email protected]>
@abelyakin abelyakin force-pushed the add-log-query-types branch from b69c7e6 to b1065fb Compare August 18, 2025 17:27
@Nexucis
Copy link
Member

Nexucis commented Aug 19, 2025

@abelyakin regarding your last comment for the Loki & ClickHouse plugin, do you need to update this PR ?

@abelyakin
Copy link
Contributor Author

abelyakin commented Aug 20, 2025

@abelyakin regarding your last comment for the Loki & ClickHouse plugin, do you need to update this PR ?

@Nexucis Yes, this PR would need updates, since logQuery response should be converted into a unified logs format. But as I mentioned in the Loki datasource plugin PR, my suggestion is to handle that as a separate follow-up PR (new feature), rather than mixing it into the current changes.

Is that okay?

@Nexucis
Copy link
Member

Nexucis commented Aug 20, 2025

yeah it's ok @abelyakin let's start by that and we will iterate base on that. Thank you for your help already !

@Nexucis Nexucis added this pull request to the merge queue Aug 20, 2025
Merged via the queue into perses:main with commit 98de45c Aug 20, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants