-
Notifications
You must be signed in to change notification settings - Fork 149
[FEATURE]: Add Quick Query Viewer #3214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
72b6d13 to
fcba16b
Compare
| <OnHover> | ||
| {extraActions} {readActions} | ||
| {extraActions} | ||
| {viewQueryAction} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably should be inside the overflow menu, we have a lot of actions and they are included in a menu for smaller screens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably should be inside the overflow menu, we have a lot of actions and they are included in a menu for smaller screens
Sorry, I did not get the point,
It is already in the OverFlowMenu. Are you suggesting, it should be removed from here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not, it should be inside <OverflowMenu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fcba16b to
efb8e18
Compare
|
@shahrokni awesome, this is definitely useful but I see we are reusing the plugin spec editor, and passing a no op when changing values to make it read only. The problem I see is with UX, users would think they can adjust the query here and change values like the datasource, legend, etc. But nothing will happen, and it might be considered an error. Should we at least have an attribute to mark the plugin editor as readonly? this will allow plugin developers to disable/hide controls when using a readonly mode. |
efb8e18 to
0d92e22
Compare
andreasgerstmayr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two UI improvements to consider:
- the modal dialog should be consistent with the other dialogs in Perses (e.g. "add panel group" dialog): it should have a title and the buttons on the bottom should be outlined
- I'd add some visual separation between the queries (either a horizontal line or collapsing functionality)
Otherwise, LGTM :)
0d92e22 to
1b67183
Compare
Signed-off-by: Seyed Mahmoud SHAHROKNI <[email protected]> Signed-off-by: Seyed Mahmoud SHAHROKNI <[email protected]> Signed-off-by: Seyed Mahmoud SHAHROKNI <[email protected]> Signed-off-by: Seyed Mahmoud SHAHROKNI <[email protected]> Signed-off-by: Seyed Mahmoud SHAHROKNI <[email protected]> Signed-off-by: Seyed Mahmoud SHAHROKNI <[email protected]> Signed-off-by: Seyed Mahmoud SHAHROKNI <[email protected]> Signed-off-by: Seyed Mahmoud SHAHROKNI <[email protected]> Signed-off-by: Seyed Mahmoud SHAHROKNI <[email protected]>
1b67183 to
74cedb4
Compare
Indeed this is misleading. That is my concern too. The point is that there is a To resolve this issue, if I am not mistaken, we need to change some stuff around plugins first. Because, PluginSpecEditor is only a wrapper on top of the const { data: plugin, isLoading, error } = usePlugin(pluginType, pluginKind);
/* Some code here*/
const { OptionsEditorComponent } = plugin;
return OptionsEditorComponent ? <OptionsEditorComponent {...others} /> : null;If you allow me we resolve this matter, first with a separate PR for plugins, and then again we get back here and add some improvements. |
|
sure if there is a property already available, then is responsibility of the plugin to do it. Thnx for the clarification |

Closes #3071
Description 🖊️
This is the Quick Query Viewer kick-off .
Test 🧪
Screenshots 🖼️
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes
See e2e docs for more details. Common issues include: