Fixes incorrect clearing of old states in queue's event objects #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are right. I thought I'd spotted a loophole yesterday morning, but your solution actually fixes it. Thank you for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queue utilizes events to wait for a new element to be added if queue was empty or wait for an element to be removed before putting a new one if it was full.
However, events can be set for previous iterations and not cleared correctly, causing either exceptions (get case) or "overflow" queue for putting with size limited queues.. See #40 for more details.
Based on the discussion there, I propose to just shift the 'clear'-calls already present by one line. We don't really care about the event state anywhere but in those locations, thus having some old state left, isn't too bad. We don't check/require it elsewhere.
TBH. I feel like it would be nice to have the event object actually have a function call "clear_and_wait", but that might be unreasonable elsewhere. Thus this fix for now.