Skip to content

Fix parsing of PHP file with annotations without context #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aik099 merged 2 commits into from
Apr 15, 2015
Merged

Fix parsing of PHP file with annotations without context #100

aik099 merged 2 commits into from
Apr 15, 2015

Conversation

@aik099
Copy link
Member

@aik099 aik099 commented Apr 15, 2015

  1. parsing of PHP file, that contained annotations without context (see Orphaned annotations causing issues #99) is no longer interrupted by exception
  2. comments, that may container annotations are parsed only, when their context is determined (class/interface/method/property)

Closes #99

mindplay-dk and others added 2 commits April 14, 2015 22:56
@mindplay-dk
avoid aggressive parsing of possible docblocks with no context
d7392a0 
note that docblocks without context found towards the end of a file are no longer considered orphaned
Adding test, that would fail when orphaned annotations are not skipped
928cc69
@aik099 aik099 added this to the 1.2.0 milestone Apr 15, 2015
aik099 pushed a commit that referenced this pull request Apr 15, 2015
Merge pull request #100 from php-annotations/bug/99
3e6d5ea 
Fix parsing of PHP file with annotations without context
@aik099 aik099 merged commit 3e6d5ea into master Apr 15, 2015
@aik099 aik099 deleted the bug/99 branch April 15, 2015 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

type-bug

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

Orphaned annotations causing issues

3 participants

@aik099 @mindplay-dk