Extend Template widget #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on SQL Queries widget, this adds param_count, memory_str, type and expandable params.
|
all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on SQL Queries widget, this adds param_count, memory_str, type and
expandable params, as proposed in #114
This shouldn't break anything, just add more information if supplied.
This makes it a bit more flexible. Not sure if param_count, memory and type are the correct ones (next to render_time), but I use params right now (duration/memory not yet). Type is for example to show if it's twig/blade/phtml etc.
@maximebf more suggestions to show?