PHP7 Support #161
Closed
PHP7 Support #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Would it make sense for us to create a php7 branch and then have this PR reopened against that branch? |
Contributor
Author
|
Yeah, I think that would be cleanest approach. A bit crappy that we will need to remember to commit changes to both branches, but trying to ifdef everything would get messy. The php7-only code is quite a bit cleaner now too I think. |
Member
|
Added the new branch: https://github.com/php-memcached-dev/php-memcached/tree/php7 Can you reopen the pull against the branch? |
Member
|
This was done in another branch, so closing ... please do join in the php7 branch though .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should bring the extension up to speed with current PHP7. Some of these changes are pulled from the previous phpng PR from @zxcvdavid but most of it is new. It compiles but hasn't been heavily tested.
I didn't ifdef due to the number of changes, so I suggest a separate php7 branch.