Skip to content

Update vswhere to 3.1.7 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Update vswhere to 3.1.7 #18

merged 1 commit into from
Sep 4, 2024

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Jul 19, 2024

I've fetched the exe from https://github.com/microsoft/vswhere/releases/tag/3.1.7, and tried the vc15, vc16 and vs17 startup scripts without any noticable issues.

@cmb69
Copy link
Member Author

cmb69 commented Jul 19, 2024

Ah, forgot: as of vswhere 3.0.1, Windows 7 is required. That's not an issue for PHP 7.2.0 and above, but older PHP versions couldn't be properly built anymore (at least not out-of-the-box). If we drop that support, we probably could also drop support for vc14, and maybe remove other stuff as well.

@cmb69
Copy link
Member Author

cmb69 commented Sep 4, 2024

If we drop that support, we probably could also drop support for vc14, and maybe remove other stuff as well.

Well, that wouldn't buy us much; while we could get rid of the registry lookups in phpsdk_setshell.bat, that code isn't a particular issue, but we would remove the possibility to build somewhat newer PHP versions with vc14, what might work (or not, haven't tested). Furthermore Visual Studio 2015 has still extended support until Okt 2025, so we may reconsider in a year or two.

Anyhow, tested with vswhere 3.1.7 for a week, and haven't noticed any issues, so I'm going to merge this PR.

@cmb69 cmb69 merged commit 1cd2c55 into php:master Sep 4, 2024
@cmb69 cmb69 deleted the cmb/vswhere-3.1.7 branch September 4, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant