Code clean-up #22
Merged
Code clean-up #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While PHP doesn't require this, it is good style, and makes the code easier to reason about.
While `Config::getSdkNugetFeedUrl()` is not used from within the project, and probably just was some experimental stuff, the method is public, so we better keep it for now, but avoid reading an undeclared class variable.
These are retrieved from within the called functions, what *might* not be the best idea, but it's what we have for now.
In practice, it's either "copy" or "rename".
From looking at the code, it seems so, but let's make sure before reading an undefined variable.
While that is changing the signature of a public method, it makes no sense to return a string, and later to convert to int again.
There shouldn't be the need for even having an interface (an abstract class should be sufficient), but we keep the interface for now.
|
Kudos to @ondrejmirtes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is fixing some basic issues which have been found via static analysis. To not endorse any particular static PHP analyser, we do not add it to the repo, and won't even tell its name.
Our main focus is on keeping BC as much as sensible, and to not break the existing code, but only to make minor adjustments to make the code better understable, and amenable to further static analysis and general improvements,