Skip to content

ext/fileinfo/tests/cve-2014-3538-nojit.phpt on macOS fails intermittently #17600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iluuu1994 opened this issue Jan 27, 2025 · 2 comments · Fixed by #17604
Closed

ext/fileinfo/tests/cve-2014-3538-nojit.phpt on macOS fails intermittently #17600

iluuu1994 opened this issue Jan 27, 2025 · 2 comments · Fixed by #17604
Labels
Bug Category: CI OS: macOS Status: Verified

Comments

@iluuu1994
Copy link
Member

Description

https://github.com/php/php-src/actions/runs/12980416896/job/36197444814

========DIFF========
     string(%d) "%s"
002+ Failed, time=1.26
002- Ok
     Done
========DONE========
FAIL Bug #66731: file: extensive backtracking, with pcre.jit=0 [ext/fileinfo/tests/cve-2014-3538-nojit.phpt]

PHP Version

8.1+ in nightly

Operating System

No response
@iluuu1994 iluuu1994 mentioned this issue Jan 27, 2025
Closed
@cmb69
Copy link
Member

cmb69 commented Jan 27, 2025

I think we just need to increase the timeout. cve-2014-3538-nojit.phpt has been forked from cve-2014-3538.phpt (3fd46e1), and later the time threshold has been increased for the latter (d1ebc3a), but not for the former (where this even might be more relevant; PCRE without JIT might even be slower).

iluuu1994 added a commit to iluuu1994/php-src that referenced this issue Jan 27, 2025
@iluuu1994
Fix cve-2014-3538 test
c3cc8dc 
Make sure we have a unique test file to work with, and incrase the time
for the nojit version to match the default version.

Closes phpGH-17600
@iluuu1994 iluuu1994 mentioned this issue Jan 27, 2025
Merged
@iluuu1994
Copy link
Member Author

@cmb69 Thanks for the hint. I created a PR.

@cmb69 cmb69 linked a pull request Jan 27, 2025 that will close this issue
Fix cve-2014-3538 test #17604
Merged
charmitro pushed a commit to wasix-org/php that referenced this issue Mar 13, 2025
@iluuu1994 @charmitro
Fix cve-2014-3538 test
ad7793e 
Make sure we have a unique test file to work with, and increase the time
for the nojit version to match the default version.

Closes phpGH-17600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Category: CI OS: macOS Status: Verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cve-2014-3538 test iluuu1994/php-src
2 participants
@iluuu1994 @cmb69