Fix bug #68591: Configuration test does not perform UID lookups #10165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
force-pushed
the
fpm_conf_test_user_group
branch
from
2c061d0 to
b2cddc6
Compare
Addition check in fpm config test to verify existence of user, group, listen.owner and listen.group.
bukka
force-pushed
the
fpm_conf_test_user_group
branch
from
b2cddc6 to
d3cae36
Compare
|
Just for the record I decided to merge this only to PHP 8.2 as there is a possibility that someone is running FPM conf test in pipeline where the users are different. I think it's more useful to break such use case as most users will probably run it on the same machine and use it mainly for verification of the config before start or reload and it's more useful for them to know that the user name is correct. It is however better to do such break in PHP 8.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional checks in fpm config test to verify existence of user, group, listen.owner and listen.group.