Skip to content

Conversation

Mingli-Yu
Copy link

Change whether to inline XXH3_hashLong_withSecret to a config option

Ref: Cyan4973/xxHash@ace22bd

Change whether to inline XXH3_hashLong_withSecret to a config option

Ref: Cyan4973/xxHash@ace22bd

Signed-off-by: Mingli Yu <[email protected]>
Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@devnexen devnexen requested a review from iluuu1994 April 12, 2023 20:51
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @devnexen Do you know how much xxhash.h has diverged from the version we bundle? Might it make sense to update it entirely?

@devnexen
Copy link
Member

Cyan4973/xxHash@ace22bd

LGTM. @devnexen Do you know how much xxhash.h has diverged from the version we bundle? Might it make sense to update it entirely?

That is definitively something to think about, do we still update like we do up to now until it comes out ? do we get a particular commit ?

@devnexen devnexen closed this in adcb38b Apr 13, 2023
@devnexen
Copy link
Member

Thank you !

@iluuu1994
Copy link
Member

Oh, it hasn't been released since? I guess then cherry-picking what we need makes sense. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants