-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Document PHP environment build configuration vars #12050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
28a1c67
to
3ad49a0
Compare
This marks the following environment variables as precious: - EXTENSION_DIR - EXTRA_CFLAGS - EXTRA_INCLUDES - EXTRA_LDFLAGS - PHP_BUILD_ARCH - PHP_BUILD_COMPILER - PHP_BUILD_PROVIDER - PHP_BUILD_SYSTEM - PHP_UNAME These variables can be used like this when configuring the PHP build: ./configure PHP_BUILD_SYSTEM="..." PHP_BUILD_PROVIDER="..." ... And they are now also shown in the `./configure --help` output. Additionally: - EXTRA_INCLUDES, EXTRA_CFLAGS and EXTRA_LDFLAGS can be now defined directly in the configure step to more intuitively append additional build options, without changing default flags for Autoconf checks.
Just for the info, @iluuu1994 this might be also a better approach for the ASAN build to pass those CFLAGS and LDFLAGS. Currently the ASAN build is unstable because the configure checks are randomly failing and variable configuration is defined. So instead of doing ./configure CFLAGS=... LDFLAGS=... this can be done and only build step takes these flags into compilation: This PR is still a bit messy and needs to be properly adjusted, CS fixed etc... |
@petk I noticed. That's very odd. I believe it's an ASAN issue. Even when Unfortunately, I cannot reproduce it locally, and the segfault message on GitHub action is unhelpful. |
Closing this in favor of #15684 and #15743 The remaining EXTRA_* variables are still in recheck what to do with them. Because the issue is that today's practices are a bit different and these type of variables are not that good idea in an ideal build system case scenario with all checks working properly etc. |
This marks some environment variables as precious and they show in the
./configure --help
output. These variables can be used like this:when customizing the build system info on some systems and are then displayed in the
phpinfo()
output.