Skip to content

Conversation

kocsismate
Copy link
Member

No description provided.

@kocsismate kocsismate marked this pull request as ready for review June 18, 2024 20:56
@kocsismate kocsismate requested a review from derickr as a code owner June 18, 2024 20:56
@kocsismate kocsismate merged commit 09303ad into php:master Jun 18, 2024
@kocsismate kocsismate deleted the date-return-fixes branch June 18, 2024 21:25
@VincentLanglet
Copy link
Contributor

Thanks @kocsismate, does it means the snippet https://3v4l.org/IZXbp will be fixed in 8.3.9 version ?

@kocsismate
Copy link
Member Author

@VincentLanglet No, it won't. I deliberately only fixed this in master, because the change has a slight BC impact: anyone extending these methods has to adapt the return types because the return type became more narrow.

@VincentLanglet
Copy link
Contributor

Thanks, so if I understand correctly, it will be in 8.4 ?

@kocsismate
Copy link
Member Author

Yes, it will!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants