Skip to content

Remove outdated libs_version.txt file #14631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2024
Merged

Conversation

petk
Copy link
Member

@petk petk commented Jun 21, 2024

This is not being synced with changes done in github.com/winlibs and served only for documentation purposes. Since the list is outdated it is simpler to remove it than maintain it updated.

P.S.: I might be wrong but I don't see this used anywhere from the quick search around. If it's really needed, then I guess it can be bumped and updated with current state of the winlibs libraries.

This is not being synced with changes done in github.com/winlibs and
served only for documentation purposes. Since the list is outdated it is
simpler to remove it than maintain it updated.
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to generate the libs_versions.txt file so that it doesn't go out of sync? I'm not sure what its purpose is, possibly documentation?

@petk
Copy link
Member Author

petk commented Jun 22, 2024

Is there a way to generate the libs_versions.txt file so that it doesn't go out of sync? I'm not sure what its purpose is, possibly documentation?

I'm not sure it can be automated in some way without some Git tags in winlibs org. Also format is problematic to parse such file. I think this file is only meant as a note for manual check to have this on one place. Not updated for several years now anymore.

@Girgias
Copy link
Member

Girgias commented Jun 23, 2024

Okay then feel free to remove

@petk petk merged commit 106581b into php:master Jun 23, 2024
2 checks passed
@petk petk deleted the patch-windows-libs-versions branch June 23, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants