Skip to content

Update the php-sdk-binary-tools to latest #14954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Jul 14, 2024

The PHP-8.3 branch CI still uses the tag php-sdk-2.2.0 which is almost five years old, so may have missed some important updates. The master branch CI uses the php_downloads_server_migration_v1 branch, which has been superseded a few months ago[1]. To always get the latest updates, we switch to the master branch of the php-sdk-binary-tools.

[1] php/php-sdk-binary-tools@19c8ccb


An alternative would be to create a new tag for php-sdk-binary-tools, but I'm not really convinced that this makes much sense, since there have mostly been a couple of updates regarding new PHP versions and URL changes over the last years, and switching to the master branch avoids having to update the Windows CI for each such small change.

The `PHP-8.3` branch CI still uses the tag `php-sddk-2.2.0` which is
almost five years old, so may have missed some important updates.  The
`master` branch CI uses the `php_downloads_server_migration_v1` branch,
which has been superseded a few months ago[1].  To always get the latest
updates, we switch to the `master` branch of the php-sdk-binary-tools.

[1] <php/php-sdk-binary-tools@19c8ccb>
@cmb69
Copy link
Member Author

cmb69 commented Jul 14, 2024

@shivammathur, what do you think about this, especially using master instead of tagging php-sdk-binary-tools.

@cmb69 cmb69 marked this pull request as ready for review July 14, 2024 13:30
@cmb69 cmb69 requested review from iluuu1994 and TimWolla as code owners July 14, 2024 13:30
@cmb69
Copy link
Member Author

cmb69 commented Jul 14, 2024

Oh, I forgot to mention that the PHP-8.1 and PHP-8.2 branches also might be updated. Haven't look closely at the details, though (and I'm not sure if that's really relevant).

@shivammathur
Copy link
Member

@cmb69
From a maintenance point of view, this is easier. But we can continue to create tags in php-sdk-binary-tools in case we have breaking changes there.

@cmb69
Copy link
Member Author

cmb69 commented Jul 15, 2024

@shivammathur, having though about this more, my conclusion is that we actually should use tags for reproducability and stability reasons (ideally, the deps series files and also the PECL deps should be versioned/tagged, too). To keep that maintainable, we should document which official repos (php-src, php-windows-builder, setup-php-sdk, and maybe others) may be affected by new tags, so that they can be updated right away. Not sure where to put that information; maybe in the README of php-sdk-binary-tools, or maybe somewhere on wiki.php.net?

@shivammathur
Copy link
Member

I agree, adding the details to the readme of php-sdk-binary-tools should be fine for our reference.
We can update the wiki as needed.

@cmb69
Copy link
Member Author

cmb69 commented Jul 16, 2024

I still haven't checked the "need" to update the PHP-8.1 and PHP-8.2 branches, but we can backport anytime.

@cmb69 cmb69 marked this pull request as ready for review July 16, 2024 14:48
@cmb69
Copy link
Member Author

cmb69 commented Jul 17, 2024

I'm closing this in favor of PR #14991, since IMO all active branches should get this update.

@cmb69 cmb69 closed this Jul 17, 2024
@cmb69 cmb69 deleted the cmb/update-php-sdk branch July 17, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants