-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Update the php-sdk-binary-tools to latest #14954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The `PHP-8.3` branch CI still uses the tag `php-sddk-2.2.0` which is almost five years old, so may have missed some important updates. The `master` branch CI uses the `php_downloads_server_migration_v1` branch, which has been superseded a few months ago[1]. To always get the latest updates, we switch to the `master` branch of the php-sdk-binary-tools. [1] <php/php-sdk-binary-tools@19c8ccb>
@shivammathur, what do you think about this, especially using |
Oh, I forgot to mention that the |
@cmb69 |
@shivammathur, having though about this more, my conclusion is that we actually should use tags for reproducability and stability reasons (ideally, the deps series files and also the PECL deps should be versioned/tagged, too). To keep that maintainable, we should document which official repos (php-src, php-windows-builder, setup-php-sdk, and maybe others) may be affected by new tags, so that they can be updated right away. Not sure where to put that information; maybe in the README of php-sdk-binary-tools, or maybe somewhere on wiki.php.net? |
I agree, adding the details to the readme of php-sdk-binary-tools should be fine for our reference. |
I still haven't checked the "need" to update the |
I'm closing this in favor of PR #14991, since IMO all active branches should get this update. |
The
PHP-8.3
branch CI still uses the tagphp-sdk-2.2.0
which is almost five years old, so may have missed some important updates. Themaster
branch CI uses thephp_downloads_server_migration_v1
branch, which has been superseded a few months ago[1]. To always get the latest updates, we switch to themaster
branch of the php-sdk-binary-tools.[1] php/php-sdk-binary-tools@19c8ccb
An alternative would be to create a new tag for php-sdk-binary-tools, but I'm not really convinced that this makes much sense, since there have mostly been a couple of updates regarding new PHP versions and URL changes over the last years, and switching to the
master
branch avoids having to update the Windows CI for each such small change.