Add tidyNode::getNextSibling() and tidyNode::getPreviousSibling() #15047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
reviewed
Jul 20, 2024
| newobj->ptdoc->ref_count++; | ||
| tidy_add_node_default_properties(newobj); | ||
| } else { | ||
| ZVAL_NULL(return_value); |
There was a problem hiding this comment.
just lost here ... not necessary anymore right ?
There was a problem hiding this comment.
You never need to set the return value to IS_NULL because the VM & JIT do it prior to the call.
I removed it to reduce the number of lines that are very very similar.
devnexen
approved these changes
Jul 20, 2024
|
FWIW I sent an email to internals to ask if anyone objects: https://externals.io/message/124530 |
Girgias
approved these changes
Jul 21, 2024
These get the next and previous sibling nodes, respectively. We can already kind of do this by using the $child array, but that's inconvenient when actually walking the tree by only using node instances. Since the class is final, there is no BC break here.
|
This looks like a useful addition to the extension to me. |
|
I merged this as no one complained and reaction was positive. Thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit refactors the code a bit to make implementation easier.
Second commit actually implements it:
These get the next and previous sibling nodes, respectively.
We can already kind of do this by using the $child array, but that's
inconvenient when actually walking the tree by only using node
instances. Since the class is final, there is no BC break here.