Autotools: Normalize 2nd arg in PHP_ADD_SOURCES_X #15088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petk
force-pushed
the
patch-normalize-sources
branch
from
3dfb1b5 to
5022f5c
Compare
By using `m4_normalize(m4_expand([...]))`, the arguments can be split into newlines without using backslashes and it makes working with lists of files a bit easier. Tested: - variables inside the argument - M4 macro expansions - dnl comments - any sequence of newlines, backslash-then-newline, multiple spaces, tabs... - quoted/unquoted arguments This now works for PHP_NEW_EXTENSION, PHP_ADD_SOURCES, PHP_ADD_SOURCES_X, and PHP_SELECT_SAPI. The m4_normalize() usage is left in the php-src config.m4 files following the 0a0d2d0 for PECL extensions until phpize will be available on all supported versions (minimum PHP 8.4).
petk
force-pushed
the
patch-normalize-sources
branch
from
5022f5c to
19a75a6
Compare
|
I'll retest and merge this also for PHP-8.4. I think everything will work ok as all edge cases that I could think of were checked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
m4_normalize(m4_expand([...])), the arguments can be split into newlines without using backslashes and it makes working with lists of files a bit easier.Tested:
Unfortunately, this wasn't ready sooner... But I'm not yet sure if to target PHP-8.4 so probably it's safer to target version after PHP-8.4.