Autotools: Append hash and opcache build directories #15132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building in out-of-source directory, instead of creating these build directories right away, this appends them to the list and creates them at the end of configure phase. These don't need to be created immediately as no files are generated in these extensions before the configure phase is finished. Also, the PHP_ADD_BUILD_DIR is moved after the PHP_NEW_EXTENSION when the more common $ext_builddir variable is available (the ext/<extension> isn't available when building with phpize).
github-actions
bot
added
Category: Build System
Extension: hash
Extension: opcache
labels
dstogov
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building in out-of-source directory, instead of creating these build directories right away, this appends them to the list and creates them at the end of configure phase. These don't need to be created immediately as no files are generated in these extensions before the configure phase is finished.
Also, the PHP_ADD_BUILD_DIR is moved after the PHP_NEW_EXTENSION when the more common $ext_builddir variable is available (the ext/ isn't available when building with phpize).