ext/mysqli: Minor clean-up #15526
Merged
ext/mysqli: Minor clean-up #15526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -126,7 +126,7 @@ int mysqli_stmt_bind_param_do_bind(MY_STMT *stmt, unsigned int num_vars, zval *a | |||
| PHP_FUNCTION(mysqli_stmt_bind_param) | |||
| { | |||
| zval *args; | |||
| int argc; | |||
| uint32_t argc; | |||
There was a problem hiding this comment.
Shouldn't the signature of mysqli_stmt_bind_param_do_bind be changed too?
There was a problem hiding this comment.
I did this, and changed some more signatures so that it returns enum_func_status, which I think a lot of other functions in mysqli should actually be declared to return instead of int which is not descriptive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.