Skip to content

Improve readonly avis error #15618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

iluuu1994
Copy link
Member

We don't track whether protected(set) is implicit, so for now always point out when the property is readonly in the error message.

/cc @SakiTakamachi I'm not sure if this helps.

Copy link
Member

@SakiTakamachi SakiTakamachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

We don't track whether protected(set) is implicit, so for now always point out
when the property is readonly in the error message.
@iluuu1994 iluuu1994 force-pushed the improve-readonly-avis-error branch from ba64dba to daeb329 Compare August 29, 2024 11:19
@iluuu1994 iluuu1994 merged commit daeb329 into php:master Aug 29, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants