Fix property_exists() for XMLReader #16079
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
requested changes
Sep 26, 2024
ext/xmlreader/php_xmlreader.c
Outdated
| return 0; | ||
| } else { | ||
| zval_ptr_dtor(&rv); | ||
| return 1; |
There was a problem hiding this comment.
This should respect the rules for isset and empty, so for empty this should call zend_is_true for example.
There was a problem hiding this comment.
Ah, yeah, I wanted to copy-paste the code I wrote for DatePeriod, but somehow I got distracted... I'm fixing it right now.
Yeah, I based my branch on PHP-8.4, but I always keep forgetting to set the right target when it comes to creating the PR. |
nielsdos
requested changes
Sep 27, 2024
kocsismate
added a commit
that referenced
this pull request
Sep 28, 2024
* PHP-8.4: Fix property_exists() and unset() for XMLReader (#16079)
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.