Fix GH-15169: stack overflow when var serialization in ext/standard/var #16159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d/var Adding a stack check here as I consider serialization to be a more sensitive place where erroring out with an exception seems appropriate.
We now handle the stack limit check in the serializer too, which prevents the regular error message from popping up.
|
The error message in the serializer is less detailed because we don't have access to the error message throwing code of zend_execute.c. While it's possible to duplicate the code, I don't think that's desirable. On master we could move it I guess. |
nielsdos
added a commit
to nielsdos/php-src
that referenced
this pull request
Oct 4, 2024
With phpGH-16204 merged, we can use the standard error message for the recently-merged phpGH-16159.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a stack check here as I consider serialization to be a more sensitive place where erroring out with an exception seems appropriate.