Skip to content

Fix test with shared zend_test #16705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Nov 5, 2024

@andypost This fixes it for me with a shared build

@nielsdos nielsdos requested a review from bukka as a code owner November 5, 2024 19:38
@andypost
Copy link
Contributor

andypost commented Nov 5, 2024

Somehow this symbol still not found

$ nm -a src/php-8.4.0RC4/modules/zend_test.so | grep zend_test_log
0000000000017700 d arginfo_zend_test_log_err_debug
000000000000f040 t zif_zend_test_log_err_debug

@andypost
Copy link
Contributor

andypost commented Nov 5, 2024

but the function exists

src/php-8.4.0RC4$ sapi/cli/php -dextension=modules/zend_test.so --rf zend_test_log_err_debug
Function [ <internal:zend_test> function zend_test_log_err_debug ] {

  - Parameters [1] {
    Parameter #0 [ <required> string $str ]
  }
  - Return [ void ]
}

@nielsdos
Copy link
Member Author

nielsdos commented Nov 5, 2024

The symbol won't show up because the C definition of the function is static, but that shouldn't matter.

@andypost
Copy link
Contributor

andypost commented Nov 5, 2024

tested locally and it works! thank you!

PS: the test was failing as previous fpm-tester was not terminated after error

@andypost
Copy link
Contributor

andypost commented Nov 5, 2024

I mean my attempt to find symbol was caused by disappointed why test fails but log was

1030+ [05-Nov-2024 19:59:44.375005] DEBUG: pid 362980, fpm_stdio_save_original_stderr(), line 81: saving original STDERR fd: dup()
1031+ [05-Nov-2024 19:59:44.375080] DEBUG: pid 362980, fpm_scoreboard_init_main(), line 38: got clock tick '100'
1032+ [05-Nov-2024 19:59:44.375208] DEBUG: pid 362980, fpm_signals_init_main(), line 219: Unblocking all signals
1033+ [05-Nov-2024 19:59:44.375233] ERROR: pid 362980, fpm_sockets_new_listening_socket(), line 233: unable to bind listening socket for address '127.0.0.1:9008': Address in use (98)
1034+ [05-Nov-2024 19:59:44.375277] ERROR: pid 362980, fpm_init(), line 72: FPM initialization failed

@nielsdos nielsdos merged commit 3f1ea1b into php:PHP-8.2 Nov 5, 2024
8 checks passed
nielsdos added a commit that referenced this pull request Nov 5, 2024
* PHP-8.2:
  Fix test with shared zend_test (#16705)
nielsdos added a commit that referenced this pull request Nov 5, 2024
* PHP-8.3:
  Fix test with shared zend_test (#16705)
nielsdos added a commit that referenced this pull request Nov 5, 2024
* PHP-8.4:
  Fix test with shared zend_test (#16705)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants