Skip to content

Support first-class callables in const-expressions #17213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 20, 2025

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Dec 18, 2024

Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable in general

@TimWolla TimWolla marked this pull request as ready for review February 11, 2025 08:17
@TimWolla TimWolla requested a review from dstogov as a code owner February 11, 2025 08:17
@TimWolla
Copy link
Member Author

The RFC looks exceedingly likely to pass, so marking this one officially ready for review for some others to take a look.

Copy link
Member

@dstogov dstogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see problems in the implementation.

@TimWolla TimWolla merged commit 2042fd3 into php:master Feb 20, 2025
9 checks passed
@TimWolla TimWolla deleted the fcc-in-const-expr branch February 20, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants