Fix curl protocols test expectation #17803
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmb69
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
This is not related to the GH runner images, but rather to an update of winlibs (winlibs/cURL#25) which has been rolled out some hours ago. The update has been done for 8.4 (staging) and master, so targeting PHP-8.4 is correct.
I'm closing #17792 as duplicate. :)
|
Ahh, sorry! I didn't see there was already an open PR for this. Thanks! But I'll merge this one then. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/php/php-src/actions/runs/13320636728/job/37204548785.
Given that this occurred on 8.4 but not on master, it makes me think the image is gradually deployed. I'm not sure if this applies only to the
windows-2022image (PHP 8.4+), or alsowindows-2019. Maybe we'll have to backport.