Skip to content

Verify bundled sources using CI #20179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+43 −0
Open

Verify bundled sources using CI #20179

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1085de
Verify bundled files
mvorisek Oct 15, 2025
b98a203
address feedback
mvorisek Oct 19, 2025
aec838a
detect added files
mvorisek Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions .github/workflows/verify-bundled-files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: Verify Bundled Files

on:
push:
pull_request:
schedule:
- cron: "0 1 * * *"
workflow_dispatch: ~

permissions:
contents: read

jobs:
VERIFY_BUNDLED_FILES:
name: Verify Bundled Files
runs-on: ubuntu-22.04
steps:
- name: git checkout
uses: actions/checkout@v5

- uses: dorny/paths-filter@v3
id: changes
with:
base: master
filters: |
opcache_jit_ir:
- 'ext/opcache/jit/ir/**'

- name: Opcache JIT IR - Download
if: ${{ !cancelled() && (steps.changes.outputs.opcache_jit_ir == 'true' || (github.event_name != 'push' && github.event_name != 'pull_request')) }}
uses: actions/checkout@v5
with:
repository: dstogov/ir
ref: 5a81104e650ebd7ac24eb63d4dff67db723a5278
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you propose to change this file every time when IR is updated?
Is it possible to parse GIT commit? or introduce some special file in the IR directory instead?

Copy link
Contributor Author

@mvorisek mvorisek Oct 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It can be replaced using simple regex or yq utility possibly.

yq command:

yq 'with(.jobs[].steps[] | select(.with.repository == "dstogov/ir") | .with.ref = "xyz"; .)' verify-bundled-files.yml

path: ext/opcache/jit/ir

- name: Opcache JIT IR - Verify files
if: ${{ !cancelled() && (steps.changes.outputs.opcache_jit_ir == 'true' || (github.event_name != 'push' && github.event_name != 'pull_request')) }}
run: |
cd ext/opcache/jit/ir
rm -r .git .github/workflows bench examples tests tools README.md TODO ir.g ir_cpuinfo.c ir_emit_c.c ir_emit_llvm.c ir_load.c ir_load_llvm.c ir_main.c ir_mem2ssa.c
git restore README
git add . -N && git diff --cached -a --exit-code . && git diff -a --exit-code .
Comment on lines +41 to +43
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comparison doesn't look robust. It's going to be broken every time when a new IR file is introduced.
Instead of using GIT tricks, the comparison could be implemented using rsync or just md5sum.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't be broken when a new IR file is introduced. It will be broken when a new "not copied" file is introduced.

Currently there are several files not copied and these files are ignored manually.

Loading