Skip to content

Zip upd master #20218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Zip upd master #20218

wants to merge 4 commits into from

Conversation

devnexen
Copy link
Member

No description provided.

@devnexen
Copy link
Member Author

devnexen commented Oct 18, 2025 •
edited
Loading

not sure about callback registering parts (ie.zip_register_ * _with_state) if we should call zend_release_fcall_info_cache on failure especially it happens only during system OOM.. wdyt @Girgias ?

@devnexen
ZipArchive::extractTo strengthen array entries type.
6cd1355 
was IS_LONG to fetch by index eventually tough ??
@Girgias
Copy link
Member

Girgias commented Oct 19, 2025

not sure about callback registering parts (ie.zip_register_ * _with_state) if we should call zend_release_fcall_info_cache on failure especially it happens only during system OOM.. wdyt @Girgias ?

zend_release_fcall_info_cache is used to release the trampoline if the FCC has one, so the best way to check if you need it is to run tests with a method name that does not exist on a class that implements __call()

@devnexen
Copy link
Member Author

Ok. if that s the case that ought to be a separate bug fix.

@devnexen devnexen marked this pull request as ready for review October 19, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Extension: zip

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devnexen @Girgias