Clarify what pm.max_spawn_rate means #20219
Open
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was confused by "number of rate", and it looks like this is actually the number of processes to spawn at one time -- so not a rate at all, but obviously we can't change the configuration variable's _name_, but we can improve the explanation! I'll submit a matching PR to php/doc-en as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was confused by
max_spawn_ratebeing described as "number of rate", and it looks like this is actually the max number of processes to spawn at one time when responding to an increase in load -- so not a rate at all, but obviously we can't change the configuration variable's name, but we can improve the explanation!Once we're good with wording I'll submit a matching PR to php/doc-en as well. This is my first PR to PHP, if I should create an issue first (or start with doc-en or do something else differently) please let me know!