phar: Simplify phar_wrapper_stat() #20222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can pass NULL instead of the error pointer, as we never use the value of the error pointer anyway.
devnexen
reviewed
Oct 19, 2025
| internal_file = ZSTR_VAL(resource->path) + 1; /* strip leading "/" */ | ||
| /* find the phar in our trusty global hash indexed by alias (host of phar://blah.phar/file.whatever) */ | ||
| if (FAILURE == phar_get_archive(&phar, ZSTR_VAL(resource->host), ZSTR_LEN(resource->host), NULL, 0, &error)) { | ||
| if (FAILURE == phar_get_archive(&phar, ZSTR_VAL(resource->host), ZSTR_LEN(resource->host), NULL, 0, NULL)) { |
There was a problem hiding this comment.
do you know if the error was not relevant/reliable enough for warning/exception usage ?
There was a problem hiding this comment.
No, the thing is that this operation needs to be silent by design.
devnexen
approved these changes
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can pass NULL instead of the error pointer, as we never use the value of the error pointer anyway.