standard: Handle negative zero in min()/max()
#20223
Open
+113
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Positive and negative zero normally compare equal, but when specifically retrieving a minimum or maximum from a list of numbers, we should consider `-0.0` to be lower than `0.0` instead of treating them the same and returning the “first match”. Fixes php#20221
mvorisek
reviewed
Oct 19, 2025
| @@ -0,0 +1,90 @@ | |||
| --TEST-- | |||
| GH-20221: max/min return wrong value if signed (negative) zero | |||
There was a problem hiding this comment.
does also apply for sort - https://3v4l.org/9UMvV
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Positive and negative zero normally compare equal, but when specifically retrieving a minimum or maximum from a list of numbers, we should consider
-0.0to be lower than0.0instead of treating them the same and returning the “first match”.Fixes #20221
Targeting PHP 8.5, since I consider this a bugfix, but not important enough for the fully-released branches.