Typed Properties #3313
Closed
Typed Properties #3313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by weak property type check.
…nversation with Joe)
…d_object_fetch_property_type_info_ex() into zend_object_fetch_property_type_info()
* master: update NEWS Expose missing flags from libzip at least >= 0.11.x Fix typo in phpdbg help. Add missing newlines to phpdbg's help for the run command. Skip test which is 64bits only update NEWS fix test portability prepare for 5.6.22RC1
We also have to remove ref sources for the immutable class case.
ASSIGN_* does not use obj flags.
This is handled by the calling code in this case.
Also fix a bug in inference for object properties: We must check that it's a non-static property, otherwise null becomes an additional valid return value.
Based on reviewer comment.
Still needs more work to make the assignment successful in more cases.
Taken from PR php#3573, minus the foreach/iteration parts.
nikic
force-pushed
the
typed_ref_properties
branch
from
7429cb1 to
5f7d376
Compare
|
Closing this PR in favor of #3734, which is the same thing but squashed. |
php-pulls
pushed a commit
that referenced
this pull request
Jan 11, 2019
RFC: https://wiki.php.net/rfc/typed_properties_v2 This is a squash of PR #3734, which is a squash of PR #3313. Co-authored-by: Bob Weinand <[email protected]> Co-authored-by: Joe Watkins <[email protected]> Co-authored-by: Dmitry Stogov <[email protected]>
|
what an improvement!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation for the new typed properties RFC.
The implementation is not quite ready for review yet, there are still a number of open issues and some behavior edge-cases regarding references may still change.