-
Notifications
You must be signed in to change notification settings - Fork 7.9k
PHP 5.6 RFC default encoding #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This has a lot of failing tests on Travis that did not fail previously. Could you check that? Moreover, some tests segfault. |
Last commit should fix segfaults. I'll check travis build later. Using travis/compile.sh configure option under my Fedora19 x86_64 (ja_JP.UTF-8)
|
Hmm. php-src's PHP-5.6 branch does not have failed tests, but this does. |
…ault charset to tests
… for default charset to tests
… for default charset to tests
@smalyshev |
@smalyshev I'll merge this if you are OK with current code and tests. Please let me know when you finish review. |
return FAILURE; | ||
encoding = mbfl_name2encoding(PG(output_encoding)); | ||
if (!encoding) { | ||
MBSTRG(http_output_encoding) = &mbfl_encoding_pass; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raising error might be better, since this code would pass any encoding when invalid encoding name is provided.
; http://php.net/default-charset | ||
;default_charset = "UTF-8" | ||
default_charset = "UTF-8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commenting out this speeds up a little. We may be better comment out all INI values if they are the same as compiled defaults
@smalyshev Thank you for your help :) |
Committed & Close. |
Implementation of this RFC.
https://wiki.php.net/rfc/default_encoding