Fix UNKNOWN default values in ext/curl and remove the deprecated param of curl_version() #5734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
force-pushed
the
unknown-default-curl
branch
from
d2c3df9 to
925258c
Compare
cmb69
reviewed
Jun 18, 2020
|
|
||
| ?> | ||
| --EXPECT-- | ||
| curl_version() expects exactly 0 parameters, 1 given |
There was a problem hiding this comment.
Should we drop this one? Looks like a pure ZPP test for me.
There was a problem hiding this comment.
Yeah, that's a good idea :)
UPGRADING
Outdated
| @@ -760,6 +760,7 @@ PHP 8.0 UPGRADE NOTES | |||
| checks for `false`. The curl_share_close() function no longer has an effect, | |||
| instead the CurlShareHandle instance is automatically destroyed if it is no | |||
| longer referenced. | |||
| . The deprecated optional parameter of curl_version() has been removed. | |||
There was a problem hiding this comment.
Suggested change
| . The deprecated optional parameter of curl_version() has been removed. | |
| . The deprecated parameter `$version` of curl_version() has been removed. |
|
The question is: is it worth the BC break or should we take a more conservative approach? @nikic ? I am ok with getting rid of the removal, too. |
|
@kocsismate No problem from my side. We removed plenty of things deprecated in 7.4. |
kocsismate
force-pushed
the
unknown-default-curl
branch
from
925258c to
f92d70c
Compare
|
Hmm, the AppVeyor test failure may be due to a segfault. |
|
@cmb69 Due to JIT, maybe? :) |
|
Maybe. I can't reproduce that test failure, unfortunately. |
|
Ah, just saw this test failing on master; so the good news is that it's not related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.