Remove unnecessary PHPDoc-alike blocks from tests #5759
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zend/tests/bug46196.phpt
Outdated
| @@ -4,8 +4,7 @@ Test restore_error_handler() function : bug #46196 | |||
| Olivier Doucet | |||
| --FILE-- | |||
| <?php | |||
| /* Prototype : void restore_error_handler(void) | |||
| * Description: Restores the previously defined error handler function | |||
| /* Description: Restores the previously defined error handler function | |||
| * Source code: Zend/zend_builtin_functions.c | |||
| * Alias to functions: | |||
There was a problem hiding this comment.
Maybe a search and drop for empty entries like this one should be considered 👍
There was a problem hiding this comment.
I'm now working on getting rid of the whole block :)
|
Agree that we should drop the whole block. |
kocsismate
force-pushed
the
remote-test-protos
branch
from
bf584de to
be2ea93
Compare
|
I've just removed almost all the blocks that I found :) Now, I'm curious how CI finishes |
kocsismate
changed the title
kocsismate
force-pushed
the
remote-test-protos
branch
from
be2ea93 to
ff5bfeb
Compare
nikic
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.