Skip to content

Add some missing closing PHP tags to tests #5958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add some missing closing PHP tags to tests #5958

wants to merge 1 commit into from

Conversation

kocsismate
Copy link
Member

@kocsismate kocsismate commented Aug 8, 2020 •
edited
Loading

These will also come handy if we want to autoformat some tests in the future.

@kocsismate kocsismate force-pushed the test-close branch 4 times, most recently from 77f3a71 to e5783e9 Compare August 9, 2020 09:07
nikic
nikic approved these changes Aug 9, 2020
View reviewed changes
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some opcache tests that need to be fixed, but generally this change is fine. We do like to have closing PHP tags in tests.

@php-pulls php-pulls closed this in 7aacc70 Aug 9, 2020
@kocsismate kocsismate deleted the test-close branch August 9, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kocsismate @nikic